Always allow localhost CORS requests #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!! Agree that maybe it would make sense to only allow localhost from a staging server. Maybe this could be configured with an environment variable then? |
|
I've added the |
5 tasks
Thank you!! I think you didn't push this change as I'm only seeing one commit on this PR? |
|
@catarak Sorry. Pushed it now! |
|
perfect :) i'll add this env to the staging server! |
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow developers to run only the client app code on their machines (see #1348), they need to be able to send requests from the app running on
localhostto a remote instance of the Editor API.Our CORS restrictions currently prohibit
localhostin production so this PR removes that restriction.I've thought about the security implications of this, and I think it's OK as the API will still require a user to be authenticated before doing anything.
It might be an idea to parallel deploy to a staging server i.e.
staging.editor.p5js.organd only allow localhost CORS there to protect developers from accidentally doing anything weird. We'd also probably want a copy of mongo too?--
I have verified that this pull request:
npm run lint)